LFS Forum - Command ban

#1 - Andi1999

Command ban

Mon 20 Apr 2015, 15:52

Hello guys !

I created a new command but not working and i really don't know what's the problem
Here is the code:

[Command("ban", "ban <username> <days> <reason>")]
        public void ban(string Msg, string[] StrMsg, Packets.IS_MSO MSO)
        {
            clsConnection Conn = Connections[GetConnIdx(MSO.UCID)];

            if (StrMsg.Length > 2)
            {
                    if (Conn.IsAdmin == 1 || Conn.IsSuperAdmin == 1 || Conn.IsModerator == 1)
                    {
                        bool BanUserfound = false;
                        int Days;
                        foreach (clsConnection C in Connections)
                        {
                            string Message20 = Msg.Remove(0, C.Username.Length + 6);

                            if (C.Username == StrMsg[1] && StrMsg[1].Length > 1)
                            {
                                BanUserfound = true;

                                Message("/ban " + C.Username + Days);
                                MsgAll("^6» " + C.PlayerName + " ^6was banned by " + Conn.PlayerName);
                                MsgAll("^6» Reason: ^7" + Message20);

                            }
                        }
                        if (BanUserfound == false)
                        {
                            InSim.Send_MTC_MessageToConnection("^7» Wrong username.", MSO.UCID, 0);
                        }
                    }

            }
            else
            {
                InSim.Send_MTC_MessageToConnection("^7» Wrong command", MSO.UCID, 0);
            }

        }

#2 - Bose321

Mon 20 Apr 2015, 15:55

So what is the error or what happens?

#3 - Andi1999

Mon 20 Apr 2015, 16:39

Is an error " Use of unassigned local variable 'Days' "

#4 - Gutholz

Mon 20 Apr 2015, 17:02

http://stackoverflow.com/questions/9233000/why-compile-error-use-of-unassigned-local-variable

#5 - Bose321

Mon 20 Apr 2015, 17:31

It's a very simple problem. You have made variable Days but it's not assigned. Exactly what the error tells you. You first have to set the Days variable.

#6 - Andi1999

Mon 20 Apr 2015, 17:56

And sow to set this variable ?
I'm coding in C#

#7 - Andi1999

Mon 20 Apr 2015, 18:05

Sorry i'm sleepy... i setted variable int Days = 0; ... but if i ban someone for 2/5/8 (is an example) in message says "You are banned for 12 hours"

#8 - Andi1999

Mon 20 Apr 2015, 18:06

Here is the new code :

[Command("ban", "ban <username> <days> <reason>")]
        public void ban(string Msg, string[] StrMsg, Packets.IS_MSO MSO)
        {
            clsConnection Conn = Connections[GetConnIdx(MSO.UCID)];

            if (StrMsg.Length > 2)
            {
                    if (Conn.IsAdmin == 1 || Conn.IsSuperAdmin == 1 || Conn.IsModerator == 1)
                    {
                        bool BanUserfound = false;
                        int Days = 0;
                        foreach (clsConnection C in Connections)
                        {
                            string Message20 = Msg.Remove(0, C.Username.Length + 6);

                            if (C.Username == StrMsg[1] && StrMsg[1].Length > 1)
                            {
                                BanUserfound = true;

                                Message("/ban " + C.Username + Days);
                                MsgAll("^6» " + C.PlayerName + " ^6was banned by " + Conn.PlayerName);
                                MsgAll("^6» Reason: ^7" + Message20);
                                
                                if (Days == 0)
                                {
                                   MsgPly("^6» You are banned for 12 hours", C.UniqueID);
                                }
                                else if (Days == 1)
                                {
                                   MsgPly("^6» You are banned for " + Days + " Day", C.UniqueID);
                                }
                                else
                                {
                                   MsgPly("^6» You are banned for " + Days + " Days", C.UniqueID);
                                }

                                 BanID(C.Username, Days);

                            }
                        }
                        if (BanUserfound == false)
                        {
                            InSim.Send_MTC_MessageToConnection("^7» Wrong username.", MSO.UCID, 0);
                        }
                    }

            }
            else
            {
                InSim.Send_MTC_MessageToConnection("^7» Wrong command", MSO.UCID, 0);
            }

        }

#9 - Andi1999

Mon 20 Apr 2015, 18:21

Anyone please :|

#10 - Gutholz

Mon 20 Apr 2015, 18:24

Quote :i setted variable int Days = 0; ... but if i ban someone for 2/5/8 (is an example) in message says "You are banned for 12 hours"

You set Days=0 and then never change its value.
So of course it stays at 0.

int Days = 0;
.
.
.
if (Days == 0)
{
MsgPly("^6» You are banned for 12 hours", C.UniqueID);

#11 - Andi1999

Mon 20 Apr 2015, 18:42

And how can I make it for multiple days?

#12 - play.net

Tue 21 Apr 2015, 07:28

int Days = int.Parse(BTT.Text); .....
try this
and u must change the BTT.Text to what u have .. stringMsg

#13 - Andi1999

Tue 21 Apr 2015, 17:21

Quote from play.net :int Days = int.Parse(BTT.Text); .....
try this
and u must change the BTT.Text to what u have .. stringMsg

Not working...

#14 - Andi1999

Thu 23 Apr 2015, 07:38

Please guys help me with this value

#15 - cargame.nl

Thu 23 Apr 2015, 09:54

Of course it doesn't work, nowhere you are busy with buttons.

If StrMsg[1] is the username then I presume StrMsg[2] is the day specification. So; Days = StrMsg[2] .. This is very basic logical coding to be honest.

#16 - Andi1999

Thu 23 Apr 2015, 16:50

Quote from cargame.nl :Of course it doesn't work, nowhere you are busy with buttons.

If StrMsg[1] is the username then I presume StrMsg[2] is the day specification. So; Days = StrMsg[2] .. This is very basic logical coding to be honest.

I tried that but not working :|

#17 - cargame.nl

Thu 23 Apr 2015, 17:03

Without any knowledge about this language I did a very quick search;
http://www.vistax64.com/vb-script/184773-retrieve-text-within-array.html

I think you first need to use the split function. But eehh yeah, can't try it myself (rephrase; don't want to try it myself) but staring to a computer screen and saying "it's not working" sure is not going to work Wink

#18 - Bose321

Thu 23 Apr 2015, 19:36

Exactly. Most people here copy a random cruise InSim and go around copy random functions from other people without any basic knowledge in programming at all and then come here saying it doesn't work.

Maybe you guys should just actually write things yourself. Start simple and work your way up. Don't expect to master this in a week, but you have to give it some time and do some research. We're not here for building you an InSim.

Oh, and please, for the love of god, set some breakpoints at a few lines, and start debugging. Look what values you receive so you can easily see what you have to do to access certain things.

You indeed have to look at the direction cargame.nl pointed you at. What you receive is "!ban usernamehere 10 reasonhere". With the split option you can split a string into parts that are put into an array of strings. If you split on a space you would get an array with the words separated:

array[0] = usernamehere
array[1] = 10
array[2] = reasonhere

This might not be the best option (since usernames and/or reasons might contain spaces), but it's to give you a simple example.