Time to learn a bit more. As GLscript is an interpreted language, try to limit the number of system calls you do, specifically using the ToNum and GetCurrentPlayerVar functions in the above code. it is more efficient for the compiler to allocate a variable than do multiple calls, so try changing it to:
<?php
Event OnSplit1( $userName ) # Player event
$sp1 = ToNum(GetCurrentPlayerVar("sp1"));
$Split1 = ToNum(GetCurrentPlayerVar("Split1"));
IF($sp1 == 0)
THEN
setCurrentPlayerVar( "sp1",$Split1);
$tData = SplitToArray( $sp1),"?");
dumpVar($tData);
ENDIF
IF ($sp1 != 0 && $Split1 > $sp1)
THEN
$difference = $Split1 - $sp1;
setCurrentPlayerVar( "sp1",$Split1);
privMsg( langEngine( "^7First split difference: ^2-{0}",ToNum($difference)));
ENDIF
IF ($sp1 != 0 && $Split1 < $sp1)
THEN
$difference = $sp1 - $Split1;
privMsg( langEngine( "^7First split difference: ^1+{0}",ToNum($difference)));
ENDIF
?>
Last edited by Krayy, .
Try using the ToNum function inside your IF statements to cast the operands to numerics. Lapper has a tendancy to assume that vars are strings rather than numbers when doing compares. i.e:
...OR...
Do the casts when your first do the variable retrievals:
<?php
...
IF ( ToNum($topSpeed) != 0 && ToNum($instantSpeed) > ToNum($topSpeed) )
THEN
...
?>
Do the casts when your first do the variable retrievals:
<?php
...
$topSpeed = ToNum(GetCurrentPlayerVar("topSpeed"));
$instantSpeed = ToNum(GetCurrentPlayerVar("InstantSpeed"));
...
?>
Last edited by Krayy, .
I think he means that he would like some help setting up lapper with a registration system, i.e. registering and storing those player details.
Start by setting a password on your server, then have a look at some of the other threads here for membership systems
Start by setting a password on your server, then have a look at some of the other threads here for membership systems
Ahhhh. I see. Sorry, I tought those functions had been put into Lapper in the last release. I'll work on a patch for it.
I've updated the lpr file, as it had a missing $ on a var reference
What errors are you getting in the lapper log?
Have a look here: http://www.lfsforum.net/showthread.php?p=1429435#post1429435
[CODE] Membership Administration
This LPR script provides a GUI to enable Admins to set a connected users authorisation level. users can be set from Visitor up to Admin, and there is also an overloaded UserIsAdmin function included to activate new admins straight away.
Once a user's auth level has been set, you can use the MemberStype stored var to limit other functions execution.
Installation:
1. Save file into your includes file as member_admin.lpr and add the filename to your addonsused.lpr file.
2. Replace the existing OnConnect functions in the main LFSLapper.lpr file with these:
Once a user's auth level has been set, you can use the MemberStype stored var to limit other functions execution.
Installation:
1. Save file into your includes file as member_admin.lpr and add the filename to your addonsused.lpr file.
2. Replace the existing OnConnect functions in the main LFSLapper.lpr file with these:
<?php
Event OnConnect( $userName ) # Player event
$NickName = GetCurrentPlayerVar("NickName");
$Posabs = GetCurrentPlayerVar("PosAbs");
$Groupqual = GetCurrentPlayerVar("GroupQual");
IF ( GetUserStoredNum("MemberType") >= $MEMBERTYPE_AFFILIATE )
THEN
LoginMember($userName);
ELSE
openPrivButton( "welc",25,50,150,15,12,-1,ISB_NONE, langEngine("%{main_welc1}%", $NickName ) );
openPrivButton( "pos",25,80,150,10,8,-1,ISB_NONE,langEngine("%{main_welc2}%",$Posabs,$Posqual,$Groupqual ) );
openPrivButton( "clos",78,120,20,10,10,-1,ISB_DARK,langEngine("%{main_accept}%"),OnConnectClose );
openPrivButton( "ref",103,120,20,10,10,-1,ISB_DARK,langEngine("%{main_deny}%"),OnConnectCloseKick );
ENDIF
EndEvent
Sub OnConnectClose( $KeyFlags,$id )
closePrivButton("welc&pos&clos&ref");
LoginNonMember(GetCurrentPlayerVar( "UserName" ));
EndSub
Sub OnConnectCloseKick( $KeyFlags,$id )
closePrivButton("welc&pos&clos&ref");
cmdLFS("/kick " . GetCurrentPlayerVar("UserName") );
EndSub
?>
Last edited by Krayy, .
Looks like the same applies to CASE statements as well, where I need to explicitly cast a const to be able to use it...i.e:
<?php
SWITCH( $mType )
CASE ToNum(MEMBERTYPE_VISITOR):
...
etc
?>
Here a cast, there a cast...
Okay, so I am defining an array using some Consts as the index like this:
consts.lpr:
utils.lpr:
When I try to use that array like this:
, I get a NULL string. Turns out that I have to explicitly cast the Const as a number to initialise the aray like this:
utils.lpr:
Hmm. Is this a problem with the parser not realising tha the Const is a numeric? Because as far as I can tell, all of the Const.lpr entries are numbers, not strings.
consts.lpr:
<?php
# Membership status
const MEMBERTYPE_UNKNOWN -1; # Player has not been here before
const MEMBERTYPE_VISITOR 0; # Player is a visitor
const MEMBERTYPE_GUEST 1; # Player is a vouched for guest
const MEMBERTYPE_JUNIOR 2; # Player is Junior Member and subject to review
const MEMBERTYPE_FULL 3; # Player is a full member
const MEMBERTYPE_MAX 4; # Used as a upper limit for iterators
?>
<?php
CatchEvent OnLapperStart()
### Global vars for Membership names ####
GlobalVar $MemberTypes;
$MemberTypes[MEMBERTYPE_VISITOR] = "Visitor";
$MemberTypes[MEMBERTYPE_GUEST] = "Guest";
$MemberTypes[MEMBERTYPE_JUNIOR] = "Junior";
$MemberTypes[MEMBERTYPE_FULL] = "Full";
$MemberTypes[MEMBERTYPE_MAX] = "MAX";
EndCatchEvent
?>
<?php
$mName = $MemberTypes[2];
?>
utils.lpr:
<?php
CatchEvent OnLapperStart()
### Global vars for Membership names ####
GlobalVar $MemberTypes;
$MemberTypes[ToNum(MEMBERTYPE_VISITOR)] = "Visitor";
$MemberTypes[ToNum(MEMBERTYPE_GUEST)] = "Guest";
$MemberTypes[ToNum(MEMBERTYPE_JUNIOR)] = "Junior";
$MemberTypes[ToNum(MEMBERTYPE_FULL)] = "Full";
$MemberTypes[ToNum(MEMBERTYPE_MAX)] = "MAX";
EndCatchEvent
?>
You have semi colons after the declaraion of the Event, and after the IF conditional tests:
Should be:
The IF is repeated further down
<?php
$MaxSessionLaps = 2;
Event OnMaxSessionLaps( $userName ); #this is line 1001
IF($SessLaps == 1;)
?>
<?php
$MaxSessionLaps = 2;
Event OnMaxSessionLaps( $userName ) #this is line 1001
IF($SessLaps == 1)
?>
This is why I got you add the RaceId var:
<?php
$RaceID = getLapperVar( "RaceId" );
SetStoredValue( "RaceID", $RaceID);
....
CatchEvent OnNewPlayerJoin( $userName ) # Player event
$PlayerRaceID = GetUserStoredValue ( "PlayerRaceID");
IF ( $PlayerRaceID == $RaceID )
THEN
# Rejoining from a previous session
ELSE
# Firstt ime in this session
SetUserStoredValue ( "PlayerRaceID", $RaceID);
ENDIF
?>
Dang, my casts were causing a crash, so this is the correct patch file:
Here's a short patch to add some extra functionality, and a potential bugfix for FinishedPos:
New GetPlayerVars: ucid, plid
New functions:
getplayervarbyucid
getplayervarbyplid
userisserveradmin
New GetPlayerVars: ucid, plid
New functions:
getplayervarbyucid
getplayervarbyplid
userisserveradmin
Last edited by Krayy, .
The problem is that Lapper sets the next race restart time when you have confimed results in either a race OR a qual ssession. It doesn't check whether the current session is a qual or race. Most race servers will only do race rotations, not quals.
if you have the source code, you could modify the file to restart only if its a race session.
Replace the line in managePacket.cs:
<?php
...
void managePacket(InSim.Decoder.RES res) // RESult (qualify or confirmed finish)
{
if (newCfg.varsLapper.AutoRestartRaceSec > 0 && ( currRace.autoRestartOn == false || newCfg.varsLapper.AutoRestartOnFirstFinished == false ))
?>
<?php
...
void managePacket(InSim.Decoder.RES res) // RESult (qualify or confirmed finish)
{
if (newCfg.varsLapper.AutoRestartRaceSec > 0 && currRace.qualMins == 0 && ( currRace.autoRestartOn == false || newCfg.varsLapper.AutoRestartOnFirstFinished == false ))
?>
How about a Global stored value database that resides in the Lapper.exe directory so that you can store common variables across all Lapper instances, like Player membership status, last server joined etc. Used like:
<?php
SetGlobalUserStoredValue( $uName, "H_Mass", GetPlayerVar($uName,"H_Mass"));
$uMass = GetGlobalUserStoredValue( $uName, "H_Mass");
?>
I think the idea of specific functions to register and retrieve Modes are a little too overly complex. Setting a Global using a Const as the value is a heck of a lot less fiddly, and it's only GL scripts that would use it, so a Callback would hav no purpose. i.e. the Lapper instance wouldn't care about the mode, unless you want to rewrite all of the internal functions that check if LFS is in a race, practice, qualify or other.
Okay...firstly, the http Lapper command doesn't actually make an http call and return a value, so you cannot use it in the way that you are doing.
The reason it doesn't is because it basically queues the web request and processes it in order, i.e. if someone else has sent a web request, yours will process after it and so forth, so the web request is not real time.
Also, the data that is returned by the web request is Queued in your player GL command queue, so the return form the web request should actually be a valid Lapper script command. Try something like this:
Web page should be something like this:
The reason it doesn't is because it basically queues the web request and processes it in order, i.e. if someone else has sent a web request, yours will process after it and so forth, so the web request is not real time.
Also, the data that is returned by the web request is Queued in your player GL command queue, so the return form the web request should actually be a valid Lapper script command. Try something like this:
<?php
$status = http("http://t3charmy.tk/LFSLapper-Cruise/test.php");
Sub ShowStatus($status)
SWITCH( $status )
CASE "0":
WriteLine( "insim is EXPIRED" );
BREAK;
CASE "1":
WriteLine( "insim EXPIRES Today" );
BREAK;
CASE "2":
WriteLine( "insim is not EXPIRED" );
BREAK;
DEFAULT:
WriteLine( "ERROR" );
BREAK;
ENDSWITCH
EndSub
?>
<?php
$date = "07/03";
$u_date = strtotime ($date);
if ($u_date == strtotime(date("d/m")) )
{ Print "1"; }
else
if ($u_date < strtotime(date("d/m")) )
{ Print "ShowStatus(0);"; }
else
{ Print "ShowStatus(2);"; }
?>
All the more reason to put it into Utils.lpr to make it a standard part of Lapper, so that there is one interface for turning the different modes on or off
From what you're saying, I'm assuming that you have modified the source code to allow for the custom variables. What I would suggest is to post the modifications that you have made to the code into the "Requests" thread so that Gai can integrate the modifications into future releases.
I would also suggest that you have a look at the Cruise.lpr addon, which has added the $Mode global variable to Lapper, and maybe integrate the drift system so that the drift score info only occurs when you are in Drift mode (Probably by typing "!mode drift")
NB: Acutaly we should move the !mode command inot Utils.lpr so that it becomes a standard part of Lapper. Then people can code addons to use Drift, Cruise or Race modes
I would also suggest that you have a look at the Cruise.lpr addon, which has added the $Mode global variable to Lapper, and maybe integrate the drift system so that the drift score info only occurs when you are in Drift mode (Probably by typing "!mode drift")
NB: Acutaly we should move the !mode command inot Utils.lpr so that it becomes a standard part of Lapper. Then people can code addons to use Drift, Cruise or Race modes
My bad...I couldn't use a FOREACH as the FOR loop is required to print from user 16 to 32 on a 2 page output.
Also, the line above that unset ($currUserName = $ListOfPlayersDoWho[$i]
is not required at all.PBs and splits are displayed in the Pitboard.lpr file, so if you comment out the includes for pitboard.lpr & pitwindow_gui.lpr in the addonsused.lpr file, then that will remove them.
When executing an OnLap, OnPB, OnPBQual or OnSplitX, how about passing the lap or split time as a parameter. That would save a call back in GL to retrieve the relevant playervar with very little overhead.
Maybe also the gap times for the OnNewGapPlayerBehind and OnNewGapPlayerBefore functions?
Maybe also the gap times for the OnNewGapPlayerBehind and OnNewGapPlayerBefore functions?
This has been asked a few times by others (myself included), as we were trying to do something similar. Bottom line is that if you are using a dedicated host, the CCH packets don't get sent at all, and if you are using a client, the CCH packets only get sent to the host each time you change viewpoint. Other LFS clients won't get the packets.
It seems to be a glaring oversight, but essentially we cannot do anything about it
It seems to be a glaring oversight, but essentially we cannot do anything about it
Updated to ver 1.0.4 for Lapper 5.926b, and also uses new DialogCreate function in updated utils.lpr file
FGED GREDG RDFGDR GSFDG