LFS Forum - Bug Reports

#201 - Yisc[NL]

Fri, 19 Feb 2016 20:01

I have no experience coding Lapper and I'm currently trying to get the source files running on my computer (with help of a professional programmer).
I did look into the Insim version issue and came to this conclusion:

In the file called 'Insim4.cs" a packet is created named "VER".
When looking at the Insim documentation "Insim.txt" that was the old way to do something with an Insim version number.
It appears that you now have to do that with a packed named "IS_ISI", which isn't used in the entire Lapper project.
Maybe this will put you on the right track to solve that issue.

#202 - Bass-Driver

Fri, 19 Feb 2016 20:25

Lapper sends ISI data to LFS with

byte[] inSimInit = myEncoder.ISI(adminPassword, 0, 0, nameApp, isLocal);
try
    {
     this.Send(inSimInit, inSimInit.Length);
    }
/////////////////////////////////////////////////////////////////////////////////////
public byte[] ISI(string adminPass, int portNum, byte mciSeconds, string nameApp, bool local)
        {
            byte[] packet = new byte[44];
            packet[0] = 44;
            packet[1] = (byte)TypePack.ISP_ISI;
            packet[2] = 1;
            packet[3] = 0;
            // Port
            packet[4] = (byte)(portNum % 256);  // LSB
            packet[5] = (byte)(portNum / 256);  // MSB

            // Flags
            if (local)
                packet[6] = (byte)ISF.MCI | (byte)ISF.LOCAL | (byte)ISF.OBH | (byte)ISF.CON;    // LSB
            else
                packet[6] = (byte)ISF.MCI | (byte)ISF.OBH | (byte)ISF.CON;    // LSB

            packet[7] = 7;          //Insim Version

            packet[8] = 0;

            packet[9] = (byte)'!';

            // Number of milli seconds between NLP or MCI packets (0=none) 
            packet[10] = 100;   // LSB
            packet[11] = 0;     // MSB
           
            System.Text.Encoding.ASCII.GetBytes(adminPass, 0, Math.Min(adminPass.Length, 16), packet, 12);
            System.Text.Encoding.ASCII.GetBytes(nameApp, 0, Math.Min(nameApp.Length, 16), packet, 28);

            return packet;
        }

Also i have found a peace of code that isnt used:

//request version Not Need in insim 4, because ISI send This
//            byte[] verreq = InSim.Encoder.VER();
//            this.Send(verreq, verreq.Length);
//retr version info

I have tried to add/changed code, but nothing works.

#203 - Yisc[NL]

Fri, 19 Feb 2016 22:37

According to the documentation, the Insim Version should be in 'packet[8]' I think.

4 bytes, 1 packet each, meaning packet[0,1,2,3]
Then you get word, which is 2 packets, meaning packet[4 and 5]
Then you get another word, which is 2 packets again, meaning packet [6 and 7]
Then you get the byte for InSimVer, meaning packet[8]

*edit*

I've tested this on my end and the message displayed in LFS about the Insim Version, is gone now.
Which means I officialy 'fixed' my first Lapper core issue Omg omg omg

#204 - Bass-Driver

Sat, 20 Feb 2016 09:34

Congrats you did. Thank you
i'm soo stupid.

i totally missed the byte[] or i just didnt know what it means. Sounds very logical to me now. Each packet is 1 byte.

To be sure it works i have add a UCO packet.
As you can see i get data from it.

Attached images

#205 - VolksTurbo

Sat, 27 Feb 2016 06:16

No sprucing it from Whesthill not read nodes?

#206 - marcal_m

Sun, 20 Mar 2016 01:21

when i open lapper, it stops working. theres nothing no error messages on the logs folder.

#207 - sinanju

Sun, 20 Mar 2016 12:07

Have you edited the default_1.ini file yet?